Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gke-operator to latest release #31961

Merged
merged 1 commit into from Apr 7, 2021
Merged

Update gke-operator to latest release #31961

merged 1 commit into from Apr 7, 2021

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Apr 7, 2021 •
edited by zube bot

No description provided.

cbron
cbron previously approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm since we shouldn’t have to do in operator anymore

@cmurphy cmurphy marked this pull request as ready for review April 7, 2021 20:42
@cmurphy
Copy link
Contributor Author

cmurphy commented Apr 7, 2021

Updated go.sum now that RC6 is actually tagged

cbron
cbron previously approved these changes Apr 7, 2021
View reviewed changes
rmweir
rmweir previously approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmurphy cmurphy dismissed stale reviews from rmweir and cbron via 42e0514 April 7, 2021 21:13
@cmurphy
Copy link
Contributor Author

cmurphy commented Apr 7, 2021

Had to fix pkg/apis/go.mod too

@cmurphy cmurphy mentioned this pull request Apr 7, 2021
Merged
@cmurphy cmurphy requested review from cbron and rmweir April 7, 2021 21:37
rmweir
rmweir approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, the other go.mod- LGTM.

@cmurphy cmurphy merged commit ffb5d64 into rancher:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedadams thedadams thedadams approved these changes

@rmweir rmweir rmweir approved these changes

@cbron cbron Awaiting requested review from cbron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmurphy @cbron @thedadams @rmweir