[WIP] Fix azure multi-environment support. #38238
Conversation
smallteeths
force-pushed
the
rancher-release-v2.6-azure
branch
3 times, most recently
from
d193eda
to
1b2d780
Compare
| @@ -10,6 +10,7 @@ replace ( | |||
| github.com/matryer/moq => github.com/rancher/moq v0.0.0-20200712062324-13d1f37d2d77 | |||
|
|
|||
| github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.2 | |||
| github.com/rancher/aks-operator => github.com/smallteeths/aks-operator v1.0.6-rc4.0.20220713031257-5fb23e55d19a | |||
There was a problem hiding this comment.
After the review, it needs to be modified to the correct dependencies.
| // Parameters: | ||
| // credConfigName - Credential config name. | ||
| // key - Fields that need to be preserved | ||
| func needToBePreserved(credConfigName, key string) bool { |
There was a problem hiding this comment.
I don't think we need this filter here. Should keep removing all credential fields.
There was a problem hiding this comment.
Ok, I removed this code and finished confirming with the front end. Let the front end get the environment from azure credential uniformly.
smallteeths
force-pushed
the
rancher-release-v2.6-azure
branch
from
1b2d780
to
63a8591
Compare
|
This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions. |
This pr fixes azure multi-environment support.
#38225