Add startup probe #40190
Merged
Add startup probe #40190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmweir
force-pushed
the
add-start-probe
branch
2 times, most recently
from
88400b4
to
66ab6ff
Compare
cbron
previously approved these changes
Jan 17, 2023
rmweir
force-pushed
the
add-start-probe
branch
from
45e23b7
to
da36dc1
Compare
cbron
previously approved these changes
Jan 18, 2023
Added startupProbe defaults when startupProbe.periodSeconds or startupProbe.failureThreshold are set.
rmweir
force-pushed
the
add-start-probe
branch
from
da36dc1
to
7296609
Compare
cbron
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#39942
Problem
Break out of #38177.
Solution
This gives another way of further delaying readiness probes. This is sometimes necessary now because startup time for rancher has increased since v2.5.
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Install chart using --set settings to set
startupProbe.periodSecondsand/orstartupProbe.failureThreshold. Just configuring one should be enough. The rest of startupProbe should use sensible defaults. It should work when configuring both as well. Can check the rancher deployment to confirm everything is as expected.Regressions Considerations