-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.9] GitHub Auth Provider: allow to search teams #45162
[v2.9] GitHub Auth Provider: allow to search teams #45162
Conversation
dead9d9
to
56852ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is solid.
Even though there's currently no tests for this provider, can you maybe add something to at least test the new functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the testing tweaks. Not overly invasive imho.
Issue:
#44907
Problem
GitHub auth provider uses GH users search API that only returns users and orgs. Therefore it's impossible to search for teams.
Solution
Given the list of orgs the user has access to pull teams for each org and do a simple prefix search on their names and add them to the search results.
Testing
Engineering Testing
Manual Testing
Automated Testing
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: