Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor crtb and prtb manager to make it more testable #45433

Merged
merged 8 commits into from
May 16, 2024
Merged

Refactor crtb and prtb manager to make it more testable #45433

merged 8 commits into from
May 16, 2024

Commits on May 9, 2024

  1. Remove crtb access to manager fields

    @JonCrowther
    JonCrowther committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e45089c View commit details
    Browse the repository at this point in the history

  2. Remove references to manager fields from prtbs

    @JonCrowther
    JonCrowther committed May 9, 2024
    Configuration menu
    Copy the full SHA
    17ea61e View commit details
    Browse the repository at this point in the history

  3. Remove manager fields that we no longer use

    @JonCrowther
    JonCrowther committed May 9, 2024
    Configuration menu
    Copy the full SHA
    751a45c View commit details
    Browse the repository at this point in the history

  4. Replace crtb manager with interface

    @JonCrowther
    JonCrowther committed May 9, 2024
    Configuration menu
    Copy the full SHA
    62e44ce View commit details
    Browse the repository at this point in the history

  5. Replace prtb manager with interface

    @JonCrowther
    JonCrowther committed May 9, 2024
    Configuration menu
    Copy the full SHA
    44a39e6 View commit details
    Browse the repository at this point in the history

  6. Add mock manager and tests for crtb_handler.go

    @JonCrowther
    JonCrowther committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9384b59 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Use a mocked manager struct and added tests

    @JonCrowther
    JonCrowther committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0eaeb7d View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Refactor managementuser crtb/prtb handler. Add mocked interface and b… 

    …asic tests for examples
    @JonCrowther
    JonCrowther committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9cd5c47 View commit details
    Browse the repository at this point in the history