Capture and log errors when writing errors #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Moioli <silvio@moioli.net>
Co-authored-by: Tom Lebreux <me@tomlebreux.com>
tomleb
approved these changes
Feb 26, 2024
|
@maxsokolovsky picked your name rather randomly from Frameworks engineers - if somebody else is preferable please let me know. Thanks in advance |
maxsokolovsky
approved these changes
Mar 5, 2024
|
@tomleb can you merge please? |
1 task
1 task
aruiz14
pushed a commit
to aruiz14/remotedialer
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code silently discarded an error which could result in goroutines/memory leaks (when
Errormessages are not delivered, the receiver might neverClose()thereadbufferon its end.Found during investigations in rancher/rancher#44576 internal reference SURE-7122.