Skip to content

Commit

Permalink
Handle upgrade from metrics server 0.2.x to 0.3.x
Browse files Browse the repository at this point in the history
  • Loading branch information
moelsayed authored and Alena Prokharchyk committed Oct 4, 2018
1 parent 496d1a4 commit 22dc192
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions cluster/addons.go
Expand Up @@ -44,6 +44,7 @@ type MetricsServerOptions struct {
RBACConfig string
Options map[string]string
MetricsServerImage string
Version string
}

type addonError struct {
Expand Down Expand Up @@ -204,10 +205,14 @@ func (c *Cluster) deployKubeDNS(ctx context.Context) error {

func (c *Cluster) deployMetricServer(ctx context.Context) error {
log.Infof(ctx, "[addons] Setting up Metrics Server")
s := strings.Split(c.SystemImages.MetricsServer, ":")
versionTag := s[len(s)-1]

MetricsServerConfig := MetricsServerOptions{
MetricsServerImage: c.SystemImages.MetricsServer,
RBACConfig: c.Authorization.Mode,
Options: c.Monitoring.Options,
Version: getTagMajorVersion(versionTag),
}
metricsYaml, err := addons.GetMetricsServerManifest(MetricsServerConfig)
if err != nil {
Expand Down
6 changes: 6 additions & 0 deletions templates/metrics.go
Expand Up @@ -113,7 +113,13 @@ spec:
imagePullPolicy: Always
command:
- /metrics-server
{{- if eq .Version "v0.3" }}
- --kubelet-insecure-tls
- --kubelet-preferred-address-types=InternalIP
- --logtostderr
{{- else }}
- --source=kubernetes.summary_api:https://kubernetes.default.svc?kubeletHttps=true&kubeletPort=10250&useServiceAccount=true&insecure=true
{{- end }}
{{ range $k,$v := .Options }}
- --{{ $k }}={{ $v }}
{{ end }}
Expand Down

0 comments on commit 22dc192

Please sign in to comment.