NodeSelector should specify string explicitly

Kubernetes doesn't accept any other value but string in nodeSelector, but if we specified ambiguous value like true, it's treated as a non-string like bool and then failed to create resource because of type mis-match, that's why we should make value of nodeSelector enclosed by double quotations to ensure value is always string
rancher · Jul 2, 2019 · d41abc7 · d41abc7
1 parent 5ff184b
commit d41abc7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/templates/coredns.go b/templates/coredns.go
@@ -122,7 +122,7 @@ spec:
       nodeSelector:
         beta.kubernetes.io/os: linux
       {{ range $k, $v := .NodeSelector }}
-        {{ $k }}: {{ $v }}
+        {{ $k }}: "{{ $v }}"
       {{ end }}
       containers:
       - name: coredns

diff --git a/templates/kubedns.go b/templates/kubedns.go
@@ -124,7 +124,7 @@ spec:
     spec:
       nodeSelector:
       {{ range $k, $v := .NodeSelector }}
-        {{ $k }}: {{ $v }}
+        {{ $k }}: "{{ $v }}"
       {{ end }}
       affinity:
         podAntiAffinity:

diff --git a/templates/nginx-ingress.go b/templates/nginx-ingress.go
@@ -188,7 +188,7 @@ spec:
       hostNetwork: true
       nodeSelector:
       {{ range $k, $v := .NodeSelector }}
-        {{ $k }}: {{ $v }}
+        {{ $k }}: "{{ $v }}"
       {{ end }}
       {{if eq .RBACConfig "rbac"}}
       serviceAccountName: nginx-ingress-serviceaccount