Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.4] Use constant instead of value for cert duration #3043

Merged
merged 1 commit into from Nov 22, 2022

Conversation

masap
Copy link
Contributor

@masap masap commented Sep 21, 2022

Signed-off-by: Masashi Honma masashi.honma@gmail.com

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
@masap masap changed the title Use constant instead of value for cert duration [release/v1.4] Use constant instead of value for cert duration Oct 7, 2022
@masap
Copy link
Contributor Author

masap commented Oct 7, 2022

Is there any comment ?

@jakefhyde jakefhyde requested a review from a team November 8, 2022 02:37
@jiaqiluo
Copy link
Member

@masap Thank you for the contribution!

@jiaqiluo jiaqiluo merged commit 56912e7 into rancher:release/v1.4 Nov 22, 2022
@masap masap deleted the fix-const branch November 24, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants