Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give configuration examples instead of flags #57

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Feb 21, 2023

Address: #56

  • Made a pass thru the docs to use configuration examples over direct binary flags. Most users will never call RKE2 directly, since it is installed as a service by default.

  • Consolidated the Linux and Windows Uninstall pages. There is little difference between the uninstall process today.

You can see this PR hosted at https://dereknola.github.io/docs-rke2/install/configuration
Signed-off-by: Derek Nola derek.nola@suse.com

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one suggestion on the resources

docs/advanced.md Outdated Show resolved Hide resolved
dereknola and others added 3 commits February 21, 2023 12:50
Signed-off-by: Derek Nola <derek.nola@suse.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants