Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rke2-killall.sh does not remove calico or cilium interfaces #1226

Closed
manuelbuil opened this issue Jun 30, 2021 · 1 comment
Closed

rke2-killall.sh does not remove calico or cilium interfaces #1226

manuelbuil opened this issue Jun 30, 2021 · 1 comment
Assignees
Labels
area/cni kind/bug Something isn't working

Comments

@manuelbuil
Copy link
Contributor

rke2-killall removes the canal interfaces but not the interfaces created by cilium or calico: https://github.com/rancher/rke2/blob/master/bundle/bin/rke2-killall.sh#L67-L72

That will create problems in case of redeploying changing the cni. For example, when deploying with cilium and removing rke2, these interfaces remain:

35: cilium_net@cilium_host: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 9001 qdisc noqueue state UP group default qlen 1000
    link/ether 7a:f2:4b:6a:fe:98 brd ff:ff:ff:ff:ff:ff
    inet6 fe80::78f2:4bff:fe6a:fe98/64 scope link 
       valid_lft forever preferred_lft forever
36: cilium_host@cilium_net: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 9001 qdisc noqueue state UP group default qlen 1000
    link/ether 4e:5e:22:41:c6:cb brd ff:ff:ff:ff:ff:ff
    inet 10.42.0.193/32 scope link cilium_host
       valid_lft forever preferred_lft forever
    inet6 fe80::4c5e:22ff:fe41:c6cb/64 scope link 
       valid_lft forever preferred_lft forever
37: cilium_vxlan: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9001 qdisc noqueue state UNKNOWN group default qlen 1000
    link/ether 46:cd:bc:30:f6:3b brd ff:ff:ff:ff:ff:ff
    inet6 fe80::44cd:bcff:fe30:f63b/64 scope link 

We should remove all possible interfaces to avoid problems

@manuelbuil manuelbuil self-assigned this Jun 30, 2021
@manuelbuil manuelbuil added this to To Triage in Development [DEPRECATED] via automation Jun 30, 2021
@manuelbuil manuelbuil moved this from To Triage to Next Up in Development [DEPRECATED] Jun 30, 2021
@brandond brandond added area/cni kind/bug Something isn't working labels Jun 30, 2021
@brandond brandond added this to the v1.22.0+rke2r1 milestone Jun 30, 2021
@manuelbuil manuelbuil moved this from Next Up to Working in Development [DEPRECATED] Jul 26, 2021
@manuelbuil manuelbuil moved this from Working to To Test in Development [DEPRECATED] Jul 27, 2021
@rancher-max
Copy link
Contributor

Validated using install script from master at get.rke2.io

Initial ip link showed:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9001 qdisc mq state UP mode DEFAULT group default qlen 1000
    link/ether 06:be:e8:ef:40:94 brd ff:ff:ff:ff:ff:ff

Confirmed that running sudo rke2-killall.sh after bringing up rke2 with calico, canal, and cilium brought back that original output. Before running killall, there were extra interfaces from the cni running.

Development [DEPRECATED] automation moved this from To Test to Done Issue / Merged PR Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cni kind/bug Something isn't working
Projects
No open projects
Development [DEPRECATED]
Done Issue / Merged PR
Development

No branches or pull requests

3 participants