Change RBAC cloud-controller-manager name #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed cloud-controller-manager RBAC to rke2-cloud-controller in clusterrole_templates.go Signed-off-by: dereknola <derek.nola@suse.com>
…into k3s-RABC-pullthru
brandond
approved these changes
Jun 4, 2021
brandond
changed the title
erikwilson
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changed the name of the rke2
cloud-controller-managerclusterrole torke2-cloud-controller-managerto prevent conflicts with other external cloud providers role names.Types of Changes
Bugfix
Verification
Spin up standard rke2 server:
kubectl get clusterrolebindingshould now outputrke2-cloud-controller-manageras a ClusterRoleBindingkubectl get clusterroleshould now outputrke2-cloud-controller-manageras a ClusterRoleLinked Issues
#1009 Is the open RKE2 issue
k3s-io/k3s#3308 Is the K3s issue that triggered this change
k3s-io/k3s#3388 Is the PR associated with the K3s issue
Further Comments