Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.22] switching to 3.5 pause images #1516

Merged
merged 3 commits into from Aug 3, 2021

Conversation

luthermonson
Copy link
Contributor

@luthermonson luthermonson commented Aug 3, 2021

Proposed Changes

Switch to rancher/pause:3.5 with proper mirrored images from mcr.microsoft.com. We are working on a mirroring script we will have run by hand. This PR can be merged after the images are up. Meets the requirements for the pause image to be hosted from a docker.io/rancher repo.

~ > docker pull rancher/pause
Using default tag: latest
Error response from daemon: manifest for rancher/pause:latest not found: manifest unknown: manifest unknown

Types of Changes

Pin new rancher/pause:3.5

Verification

Linked Issues

#1515

Further Comments

propsosed shell script to pull/tag/push images into rancher/pause

# windows
docker pull mcr.microsoft.com/oss/kubernetes/pause:3.5-windows-1809-amd64
docker pull mcr.microsoft.com/oss/kubernetes/pause:3.5-windows-2004-amd64
docker pull mcr.microsoft.com/oss/kubernetes/pause:3.5-windows-20H2-amd64

docker tag mcr.microsoft.com/oss/kubernetes/pause:3.5-windows-1809-amd64 rancher/pause:3.5-windows-1809-amd64
docker tag mcr.microsoft.com/oss/kubernetes/pause:3.5-windows-2004-amd64 rancher/pause:3.5-windows-2004-amd64
docker tag mcr.microsoft.com/oss/kubernetes/pause:3.5-windows-20H2-amd64 rancher/pause:3.5-windows-20H2-amd64

docker push  rancher/pause:3.5-windows-1809-amd64
docker push  rancher/pause:3.5-windows-2004-amd64
docker push  rancher/pause:3.5-windows-20H2-amd64


# linux
docker pull mcr.microsoft.com/oss/kubernetes/pause:3.5-linux-amd64
docker tag mcr.microsoft.com/oss/kubernetes/pause:3.5-linux-amd64 rancher/pause:3.5-linux-amd64
docker push  rancher/pause:3.5-linux-amd64

docker manifest create \
rancher/pause:3.5 \
--amend rancher/pause:3.5-linux-amd64 \
--amend rancher/pause:3.5-windows-1809-amd64 \
--amend rancher/pause:3.5-windows-2004-amd64 \
--amend rancher/pause:3.5-windows-20H2-amd64 

export DOCKER_CLI_EXPERIMENTAL=enabled
docker manifest annotate --os windows --arch amd64 --os-version "10.0.17763.1817" rancher/pause:3.5 rancher/pause:3.5-windows-1809-amd64
docker manifest annotate --os windows --arch amd64 --os-version "10.0.19041.867" rancher/pause:3.5 rancher/pause:3.5-windows-2004-amd64
docker manifest annotate --os windows --arch amd64 --os-version "10.0.19042.867" rancher/pause:3.5 rancher/pause:3.5-windows-20H2-amd64

#  verify that os.version is listed for windows images
docker manifest inspect docker.io/rancher/pause:3.5

docker manifest push docker.io/rancher/pause:3.5

@luthermonson luthermonson requested a review from a team as a code owner August 3, 2021 15:20
@brandond
Copy link
Contributor

brandond commented Aug 3, 2021

This still won't fix airgap, as you're putting rancher/pause:3.5-windows-1809-amd64 in the tarball, but using rancher/pause:3.5 as the pause image. The tags need to match exactly.

Development [DEPRECATED] automation moved this from Working to Approved PRs Aug 3, 2021
@luthermonson luthermonson merged commit 3a3fe99 into rancher:master Aug 3, 2021
Development [DEPRECATED] automation moved this from Approved PRs to Done Issue / Merged PR Aug 3, 2021
@luthermonson luthermonson changed the title [wip] switching to 3.5 pause images [Release 1.22] switching to 3.5 pause images Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows kind/bug Something isn't working
Projects
No open projects
Development [DEPRECATED]
Done Issue / Merged PR
Development

Successfully merging this pull request may close these issues.

None yet

3 participants