Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for External IP for Windows nodes Rancher installer.. #1753

Merged
merged 2 commits into from Sep 2, 2021
Merged

Adding support for External IP for Windows nodes Rancher installer.. #1753

merged 2 commits into from Sep 2, 2021

Conversation

phillipsj
Copy link
Contributor

Signed-off-by: Jamie Phillips jamie.phillips@suse.com

Proposed Changes

This fixes formatting and adds better detection of the address to send the correct cattle headers.

Types of Changes

This is an enhancement/bugfix.

Verification

Pass -Address and an IP when registering a windows node. The node should display the external ip address in the nodes section of the cluster explorer.

Linked Issues

Further Comments

@phillipsj phillipsj requested a review from a team as a code owner September 2, 2021 18:42
@phillipsj phillipsj self-assigned this Sep 2, 2021
@phillipsj phillipsj added this to Working in Development [DEPRECATED] via automation Sep 2, 2021
@phillipsj phillipsj added this to the Rancher 2.6.x milestone Sep 2, 2021
Signed-off-by: Jamie Phillips <jamie.phillips@suse.com>
windows/rke2-install.ps1 Outdated Show resolved Hide resolved
Development [DEPRECATED] automation moved this from Working to Approved PRs Sep 2, 2021
Signed-off-by: Jamie Phillips <jamie.phillips@suse.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1753 (092fc44) into master (1d36ab1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1753   +/-   ##
======================================
  Coverage    8.63%   8.63%           
======================================
  Files          21      21           
  Lines        1877    1877           
======================================
  Hits          162     162           
  Misses       1688    1688           
  Partials       27      27           
Flag Coverage Δ
unittests 8.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d36ab1...092fc44. Read the comment docs.

@phillipsj phillipsj merged commit 82ca956 into rancher:master Sep 2, 2021
Development [DEPRECATED] automation moved this from Approved PRs to Done Issue / Merged PR Sep 2, 2021
@phillipsj phillipsj deleted the feature/windows-external-ip branch September 2, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development [DEPRECATED]
Done Issue / Merged PR
Development

Successfully merging this pull request may close these issues.

None yet

3 participants