Adding support for External IP for Windows nodes Rancher installer.. #1753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jamie Phillips jamie.phillips@suse.com
Proposed Changes
This fixes formatting and adds better detection of the address to send the correct cattle headers.
Types of Changes
This is an enhancement/bugfix.
Verification
Pass -Address and an IP when registering a windows node. The node should display the external ip address in the nodes section of the cluster explorer.
Linked Issues
Further Comments