Remove the broken/unused/unneeded $AIRGAP_CHECKSUMS_URL argument #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents these useless outputs in the command output:
Directory: C:\usr
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 11/09/2021 10:13 local
this allows for better error handling/reporting like mentioned in rancher#1804
this closes rancher#1804
rgl
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
======================================
Coverage 8.59% 8.59%
======================================
Files 21 21
Lines 1885 1885
======================================
Hits 162 162
Misses 1696 1696
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
phillipsj
approved these changes
Sep 15, 2021
brandond
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fixes the install.ps1 problem described at #1804
I also took the opportunity to enable the powershell strict mode and prevent New-Item from outputting the useless directory object to stdout.
Types of Changes
Bugfix.
Verification
Install the agent on Windows using the modified install.ps1 file.
Linked Issues
#1804