Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update K3s to latest engine-1.21 #1818

Merged
merged 1 commit into from Sep 14, 2021
Merged

Conversation

Oats87
Copy link
Contributor

@Oats87 Oats87 commented Sep 14, 2021

Proposed Changes

Bump K3s to the latest engine-1.21 commit ID to implement the etcd-member-management controller

Types of Changes

Engine changes

Verification

  1. Create a multi-node etcd-backed RKE2 cluster.
  2. Perform an etcdctl member list command using a downloaded etcdctl binary from the etcd project on any of the etcd nodes similar to:
etcdctl --cacert=/var/lib/rancher/rke2/server/tls/etcd/server-ca.crt --cert=/var/lib/rancher/rke2/server/tls/etcd/client.crt --key=/var/lib/rancher/rke2/server/tls/etcd/client.key member list -w table

and observe that there should be N etcd members listed, where N is the number of etcd nodes in the cluster.
3. Annotate one of your etcd nodes (preferably not the "bootstrap" node) with the annotation etcd.rke2.cattle.io/remove=true. List/describe the annotations of the node and watch the etcd.rke2.io/removed-node-name annotation be set to the etcd node name that corresponded to the list of nodes in the member list command from above.
4. Re-run the etcdctl member list and observe that the etcd member is NOT listed in the list anymore. Additionally, looking at the logs of etcd and notice it is crashing.

Linked Issues

#1816

Further Comments

Signed-off-by: Chris Kim <oats87g@gmail.com>
@Oats87 Oats87 requested a review from a team as a code owner September 14, 2021 17:47
@Oats87 Oats87 changed the title Update engine-1.21 Update K3s to latest engine-1.21 Sep 14, 2021
Copy link
Member

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briandowns
Copy link
Member

Here's the k3s diff: k3s-io/k3s@f2c7882...34de120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants