update windows uninstall and install scripts

[rosskirkpat]

Proposed Changes

Update Windows uninstall and install scripts:

• will now clean env vars (including machine env vars) on uninstall
• ctr commands should now successfully complete if it is present
• fix a few typos throughout both scripts
• will now clean custom directories for CATTLE_AGENT_BIN_PREFIX, CATTLE_AGENT_VAR_DIR, CATTLE_AGENT_CONFIG_DIR during uninstall
• added retries to the query of the v3/connect/config-yaml endpoint as the content can take longer than expected to generate
• added additional INFO outputs to better understand what succeeds when the script runs
• enable Strict mode in all scripts
• fix default directory for CATTLE_AGENT_VAR_DIR now defaults to C:/var/lib/rancher/agent instead of C:/etc/rancher/agent
• added CATTLE_AGENT_BIN_PREFIX env var as it exist in system agent install script. defaults to C:/usr/local
• declare CATTLE_AGENT_VAR_DIR, CATTLE_AGENT_CONFIG_DIR , CATTLE_AGENT_BIN_PREFIX as machine env vars
• fix naming issue when looking for airgap tarballs for commit testing

Docs should be updated to reflect a few new env vars in the install script and what they do/how to use them

Types of Changes

bug fixes and expanding the functionality of the install and uninstall scripts

Verification

the updated scripts were used on Windows rke2 agent nodes in custom clusters to verify they worked.

Linked Issues

#1873
#1890

[rosskirkpat]

I have a few more testing scenarios that I would like to run through prior to merging but every test that I have run so far has the updated scripts working as expected.

[rancher-max]

There's at least two issues with installing via commit:

1. Random bracket that shouldn't exist on line 163 in install.ps1
2. Something wrong with checksums.
   See error when using this install script:

PS C:\Users\Administrator> ./install.ps1 -Commit 9517e166151f202814d5a8856ab038ec53f43d4a
[INFO] Windows feature: 'Containers' is installed. Installation will proceed.
Using stable channel of rke2 for installation
[INFO] using commit 9517e166151f202814d5a8856ab038ec53f43d4a} as release
Get-AirgapChecksums : A parameter cannot be found that matches parameter name 'Uri'.
At C:\Users\Administrator\install.ps1:567 char:41
+ ... _EXPECTED = Get-AirgapChecksums -CommitHash $Commit -StorageUrl $STOR ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Get-AirgapChecksums], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,Get-AirgapChecksums 

[rosskirkpat]

@rancher-max the errant bracket has been removed and this should also fix the checksum issue as the commitHash was being passed with the }. Would you be able to re-test?

[phillipsj]

LGTM!

[rancher-max]

@rancher-max the errant bracket has been removed and this should also fix the checksum issue as the commitHash was being passed with the }. Would you be able to re-test?

I gave it a try, but still get the checksum error 🤔

 ./install.ps1 -Commit 9517e166151f202814d5a8856ab038ec53f43d4a
[INFO] Windows feature: 'Containers' is installed. Installation will proceed.
Using stable channel of rke2 for installation
[INFO] using commit 9517e166151f202814d5a8856ab038ec53f43d4a as release
Get-AirgapChecksums : A parameter cannot be found that matches parameter name 'Uri'.
At C:\Users\Administrator\install.ps1:567 char:41
+ ... _EXPECTED = Get-AirgapChecksums -CommitHash $Commit -StorageUrl $STOR ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Get-AirgapChecksums], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,Get-AirgapChecksums

Looking into the parameters, I found one passing Uri on line 421:

    if (!(Test-Download -Url $AirgapChecksumsUrl)) {
        $AirgapChecksumsUrl = "$StorageUrl/rke2-images.$suffix$CommitHash.tar.gz.sha256sum"
    }

Changing that to Url resolves the error, but leads to a new one:
Get-AirgapChecksums : A parameter cannot be found that matches parameter name 'Path'.

This seems to occur on line 426: return Find-Checksum -Path $TempAirgapChecksums -Pattern "rke2-images.$suffix.tar" which I updated Path to ChecksumFilePath.

This then appears to work without compilation errors, but gives an error at the end:

PS C:\Users\Administrator> ./install.ps1 -Commit 9517e166151f202814d5a8856ab038ec53f43d4a
[INFO] Windows feature: 'Containers' is installed. Installation will proceed.
Using stable channel of rke2 for installation
[INFO] using commit 9517e166151f202814d5a8856ab038ec53f43d4a as release
[INFO] downloading airgap checksums at https://storage.googleapis.com/rke2-ci-builds/rke2-images.windows-amd649517e166151f202814d5a8856ab038ec53f43d4a.tar.zst.sha256sum
[ERROR] Checksum file wasn't found: C:\Users\ADMINI~1\AppData\Local\Temp\2\rke2-install\rke2-images.checksums

@rosskirkpat

[phillipsj]

LGTM!

[phillipsj]

LGTM

[codecov-commenter]

Codecov Report

Merging #1872 (943d6cc) into master (2f6048e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1872      +/-   ##
=========================================
+ Coverage    8.58%   8.59%   +0.01%     
=========================================
  Files          21      21              
  Lines        1887    1884       -3     
=========================================
  Hits          162     162              
+ Misses       1698    1695       -3     
  Partials       27      27              

Flag	Coverage Δ
unittests	8.59% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cli/cmds/root.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6048e...943d6cc. Read the comment docs.

[phillipsj]

LGTM