Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Upgrade nginx chart to version 4.0.305 #1944

Closed

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Upgrade Nginx ingress to version 4.0.3

Types of Changes

chart upgrade

Verification

  • Install rke2 cluster

Linked Issues

Further Comments

@galal-hussein galal-hussein requested a review from a team as a code owner October 8, 2021 19:11
Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: disregard

Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no I was right, needs an update to the ingress-nginx tag in scripts/build-images.

@@ -21,7 +21,7 @@ xargs -n1 -t docker image pull --quiet << EOF >> build/images-core.txt
${REGISTRY}/rancher/klipper-helm:v0.6.4-build20210813
${REGISTRY}/rancher/pause:${PAUSE_VERSION}
${REGISTRY}/rancher/mirrored-jettech-kube-webhook-certgen:v1.5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this to the one used by the new chart.

You might be able to hold off on this PR though, as I'm about to merge #1827 which has these updates rolled in already.

@galal-hussein
Copy link
Contributor Author

Closing this PR because its not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants