Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use new fips compliant images #23

Merged
merged 1 commit into from Jun 5, 2020

Conversation

briandowns
Copy link
Member

Replaces default Kubernetes and EtcD registries and repositories with the FIPS 140-2 compliant images.

@ibuildthecloud
Copy link
Contributor

What are the other changes in this PR? Are they just cosmetic or did something change?

Copy link
Contributor

@galal-hussein galal-hussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briandowns
Copy link
Member Author

What are the other changes in this PR? Are they just cosmetic or did something change?

Some cosmetic. I added rke2 to the .gitignore since it complied and left a bin at the root. The string concat reads cleaner and removes a few allocations and reflection from Sprintf call.

@briandowns
Copy link
Member Author

@ibuildthecloud are we good to go for this one?

@ibuildthecloud ibuildthecloud merged commit e02bb2f into rancher:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants