Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rpm installation support for SLE systems #2549

Merged
merged 2 commits into from Mar 17, 2022
Merged

Add rpm installation support for SLE systems #2549

merged 2 commits into from Mar 17, 2022

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Mar 4, 2022 •
edited

Proposed Changes

  • Adding ability to install rke2 on SLE systems using rpms
  • Fixing uninstall script to detect both rpm and tarball installations on SLE
  • Fix method conflict to to detect tarball installation

This change applies design decision in #2409

Types of Changes

Enhancement

Verification

Linked Issues

#2628

Further Comments

@galal-hussein galal-hussein requested a review from a team as a code owner March 4, 2022 23:18
@galal-hussein
fix method_conflict function to detect tarball installation on SLE
c54da78 
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein merged commit 115d916 into rancher:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@dereknola dereknola dereknola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@galal-hussein @brandond @dereknola