Consolidate staticPod timeout to static 30 minutes #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
force-pushed
the
timeout_static30
branch
2 times, most recently
from
00233e6
to
09cacf2
Compare
brandond
requested changes
Jul 19, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
timeout_static30
branch
from
3cb05cc
to
0d6552c
Compare
Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Jul 19, 2022
brandond
requested changes
Jul 19, 2022
brandond
requested changes
Jul 19, 2022
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Jul 19, 2022
briandowns
approved these changes
Jul 19, 2022
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Jul 19, 2022
* Consolidate staticPod timeout to static 30 minutes * Close files and simplify filter * Convert to PollImmediate Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/rke2
that referenced
this pull request
Jul 19, 2022
* Consolidate staticPod timeout to static 30 minutes * Close files and simplify filter * Convert to PollImmediate Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
Simplify and consolidate the timeout for Static Pod Manifest check. Now there is only 1 timeout, a static 20 second check for 30 minutes.
Types of Changes
Verification
RKE2 startup on single node.
Linked Issues
harvester/harvester#2336
Further Comments