Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation with PSP removal #3360

Merged
merged 3 commits into from Oct 13, 2022
Merged

Update documentation with PSP removal #3360

merged 3 commits into from Oct 13, 2022

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Sep 16, 2022 •
edited

Proposed Changes

  • Fixes to documentation:
    • Information about the new cis profile 1.23
    • Adding Distinction between running RKE2 v1.25.0 and older versions
    • Adding cis-1.23 self assessment guide

Types of Changes

Documentation

Verification

N/A

Linked Issues

@galal-hussein galal-hussein requested a review from a team as a code owner September 16, 2022 20:10
brandond
brandond requested changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits. There are a bunch of things that are done no matter what the policy flag is set to (as long as its a valid string for that RKE2 release); for those I think we can drop the version language.

docs/known_issues.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/hardening_guide.md Outdated Show resolved Hide resolved
docs/security/pod_security_standards.md Outdated Show resolved Hide resolved
docs/security/pod_security_standards.md Outdated Show resolved Hide resolved
@cwayne18
Copy link
Contributor

@galal-hussein thanks for this! Can you please make sure to fill out the PR template? I'm trying to get better at making sure we're filling them out for every PR

@galal-hussein galal-hussein mentioned this pull request Sep 28, 2022
Merged
@cwayne18
Copy link
Contributor

cwayne18 commented Oct 7, 2022

can we get this landed?

@brandond brandond mentioned this pull request Oct 13, 2022
Closed
@galal-hussein galal-hussein merged commit 532aed3 into rancher:master Oct 13, 2022
@dereknola dereknola mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@briandowns briandowns briandowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@galal-hussein @cwayne18 @brandond @briandowns