Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k3s for servicelb ccm change; add servicelb support #3404

Merged
merged 6 commits into from Sep 30, 2022

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Sep 30, 2022

Proposed Changes

Bump k3s for servicelb ccm change; add servicelb support

Needs docs update

Types of Changes

version bump; new feature

Verification

  • Note presence of new server CLI flags to enable servicelb, configure servicelb namespace, and override cloud-controller-manager image
  • Start rke2 server --enable-servicelb - note that services of type LoadBalancer can be deployed successfully.
  • Note that normal cloud-controller functionality works
  • Note that cloud-controller-manager does not run if --disable-cloud-controller is set and --enable-servicelb is not.

Linked Issues

Further Comments

Waiting on merge+tag:

Updates k3s: k3s-io/k3s@1d42f46...0270395

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Also don't drop the servicelb-namespace flag.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner September 30, 2022 16:01
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants