[release-1.24] Don't handle kube-proxy in static pod cleanup #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't technically a control-plane component, and shouldn't be handled by the control-plane static pod cleanup. Instead, handle it within the static pod executor's agent setup path. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit aec5998)
Codecov ReportBase: 18.59% // Head: 18.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release-1.24 #3836 +/- ##
================================================
- Coverage 18.59% 18.53% -0.07%
================================================
Files 26 26
Lines 2318 2331 +13
================================================
+ Hits 431 432 +1
- Misses 1849 1861 +12
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
briandowns
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Don't handle kube-proxy in static pod cleanup
This isn't technically a control-plane component, and shouldn't be
handled by the control-plane static pod cleanup. Instead, handle it
within the static pod executor's agent setup path.
Types of Changes
bugfix
Verification
See linked issue
Linked Issues
Further Comments