[Release-1.25]Bump golangci-lint for golang 1.20 compat and fix warnings #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 30f83b9)
|
We don't bump golang versions in release branches, we just match with what version upstream uses. I'm not sure this PR is necessary, as we will never bump golang to 1.20 for this branch. |
|
@dereknola we should keep the linter up to date regardless of what golang version is in use, and the new linter version raised valid findings on the flag vars shadowing built-in function names. Since we changed the flags on the master branch, and we backport everything, we also need to backport this. |
brandond
approved these changes
May 9, 2023
dereknola
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Backporting from #4108
Types of Changes
Verification
Linked Issues
Further Comments