Fix static pod UID generation and cleanup #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
static_pod_uid2
branch
3 times, most recently
from
58122d1
to
d4bed77
Compare
Partial revert of 53d8510 This reverts static pod UID generation to use the same logic as the kubelet, in favor of manually removing stale static pods for etcd and the apiserver. The fixed pod UID was an attempt to trick the kubelet into syncing static pod containers even when the apiserver was unavailable, but it had the downside of preventing it from ever updating the mirror pods. This was confusing for end users who expect the pods visible via the apiserver to reflect what is actually running on the nodes. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
static_pod_uid2
branch
from
d4bed77
to
6e78b82
Compare
briandowns
approved these changes
Jul 31, 2023
galal-hussein
approved these changes
Jul 31, 2023
This was referenced Aug 5, 2023
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Partial revert of 53d8510
This reverts static pod UID generation to use the same logic as the kubelet, in favor of manually removing stale static pods for etcd and the apiserver. The fixed pod UID was an attempt to trick the kubelet into syncing static pod containers even when the apiserver was unavailable, but it had the downside of preventing it from ever updating the mirror pods. This was confusing for end users who expect the pods visible via the apiserver to reflect what is actually running on the nodes.
Types of Changes
bugfix
Verification
See linked issue
Linked Issues
Further Comments
Note for QA: Please be sure to test this on a multi-server split-role (etcd-only/control-plane-only) cluster. I have validated it locally but would appreciate an extra set of eyes.