Fix startup with missing etcd static pod manifest #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like the intent was to ignore the file not found error, but apparently someone forgot that a bare return would use the err value returned by ReadFile, not the default nil from the named return. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Oats87
approved these changes
Nov 10, 2020
briandowns
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Properly start up if the etcd static pod manifest has been deleted. This is created on first startup, but on subsequent startups where we attempt to read InitialOptions from the manifest, rke2 would fail because the 'no such file or directory' error was not properly suppressed.
Types of Changes
Verification
See steps from linked issue
Linked Issues
Related to #373
Further Comments