Add new network policy for ingress controller webhook #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
commented
Feb 21, 2024
| @@ -120,13 +122,44 @@ var networkIngressPolicy = v1.NetworkPolicy{ | |||
| { | |||
| Protocol: &tcp, | |||
| Port: &intstr.IntOrString{ | |||
| IntVal: int32(80), | |||
| StrVal: "http", | |||
There was a problem hiding this comment.
note: targeting by name is more correct, as the numeric ports can be set by chart values.
brandond
commented
Feb 21, 2024
| }, | ||
| }, | ||
| { | ||
| Protocol: &tcp, | ||
| Port: &intstr.IntOrString{ | ||
| IntVal: int32(443), | ||
| StrVal: "https", |
There was a problem hiding this comment.
note: targeting by name is more correct, as the numeric ports can be set by chart values.
brandond
commented
Feb 21, 2024
| { | ||
| Protocol: &tcp, | ||
| Port: &intstr.IntOrString{ | ||
| StrVal: "webhook", |
There was a problem hiding this comment.
note: targeting by name is more correct, as the numeric ports can be set by chart values.
Unfortunately we can't just add this to the existing netpol, as we document that it is not updated once the namespace annotation has been set. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
allow-ingress-webhook
branch
from
3e046fb
to
78178ee
Compare
dereknola
approved these changes
Feb 21, 2024
briandowns
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add new network policy for ingress controller webhook.
The ingress-nginx chart added a validating webhook a while back, but we did not have a policy that allowed access to it. Access was being allowed by the overly broad network policy that we removed in #5318.
Unfortunately we can't just add this to the existing netpol, as we document that it is not updated once the namespace annotation has been set.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments