Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Unit Testing in GitHub Actions #5676

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Apr 4, 2024

Proposed Changes

Unit testing CI was disable because it was broken for along time. This PR reenables it with updated action versions and fixes to broken unit tests.

Types of Changes

Testing, CI

Verification

Unit test action should pass

Testing

Linked Issues

#5677

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner April 4, 2024 19:05
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola merged commit ff07673 into rancher:master Apr 8, 2024
3 checks passed
@dereknola dereknola deleted the enable_unit branch April 11, 2024 17:26
dereknola added a commit to dereknola/rke2 that referenced this pull request Apr 17, 2024
* Remove invalid stale input

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Enable unit testing in CI

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/rke2 that referenced this pull request Apr 17, 2024
* Remove invalid stale input

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Enable unit testing in CI

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request May 3, 2024
* Remove invalid stale input

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Enable unit testing in CI

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request May 3, 2024
* Remove invalid stale input

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Enable unit testing in CI

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants