Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.30] Move to fatal error for cis-1.23 profile value #5781

Merged
merged 2 commits into from
May 6, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Apr 15, 2024

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

  • Move cis-1.23 value from a warning to a fatal error.
  • Remove mention of cis-1.23 from "valid values" in the help output

Types of Changes

Flag Deprecation

Verification

Starting rke2 with profile: cis-1.23 now causes a fatal error.
$ sudo useradd -r -c "etcd user" -s /sbin/nologin -M etcd -U
$ sudo ./bin/rke2 server --profile=cis-1.23
FATA[0000] cis-1.23 profile is deprecated. Please use 'cis' instead.

Testing

Linked Issues

#5780

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner April 15, 2024 17:40
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola merged commit ebe1d35 into rancher:master May 6, 2024
5 checks passed
@dereknola dereknola deleted the cis_dep_130 branch May 21, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants