Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving logging and error readability for rke2-uninstall.sh script #6237

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iamsarthakk
Copy link

@iamsarthakk iamsarthakk commented Jun 21, 2024

Proposed Changes

Currently, whenever uninstall script fails it is not immediately clear that it failed and we need to address the failure issues. These changes adds clear messaging in red colour if the script fails at any point with better logging.

It doesn't need documentation changes

Types of Changes

Improving logging and error readability in rke2-uninstall script

Verification

Changes can be verified by running the uninstall script on rancher based system

Testing

It doesn't have any changes which need unit tests or integration tests

Linked Issues

User-Facing Change

NONE

Further Comments

@iamsarthakk iamsarthakk requested a review from a team as a code owner June 21, 2024 15:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.09%. Comparing base (71d00cc) to head (1058d39).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6237      +/-   ##
==========================================
- Coverage   26.10%   26.09%   -0.01%     
==========================================
  Files          32       32              
  Lines        2697     2698       +1     
==========================================
  Hits          704      704              
- Misses       1947     1948       +1     
  Partials       46       46              
Flag Coverage Δ
inttests 9.82% <ø> (-0.01%) ⬇️
unittests 18.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants