-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate core/v1 controller in shepherd to resolve missing resources #166
Comments
@floatingman Do we plan to address this soon? Checking to see because we have a dependency on this issue as there are some resources that are currently missing (Ex: limitrange) that we need for our automation |
@Priyashetty17 We will probably pick this up in the next sprint that is starting next week. |
@Priyashetty17 I've reviewed this, and it looks like the controllers for core/v1 come directly from the Wrangler project and are not part of the Rancher-generated controllers. So, any functionality using Wrangler with the test framework should match what Rancher uses. Here is where the controllers are. https://github.com/rancher/wrangler/tree/master/pkg/generated/controllers/core |
@floatingman Thanks for looking into this! Sice limitranges is not availabe in this version, do you suggest we use dynamic client for limitranges? cc @igomez06 |
HI @floatingman and @Priyashetty17, the limit ranges is a new feature on k8s right? Or is this something added from Rancher? Dan my thinking is we generate the core controllers in shepherd, because we need the session clean up added to it anyways. We wouldn't want to import it from the wrangler repo. |
@igomez06 Limitranges is a k8s feature - https://kubernetes.io/docs/concepts/policy/limit-range/ |
In that case @floatingman , we need to generate the controller in shepherd it should work with our k8s version we have in shepherd, but please check. This has nothing to do with the wrangler version. |
It appears that the core/v1 controller being used is outdated, resulting in the absence of resources such as limitranges. @igomez06 suggested that the core/v1 controller needs to be generated in shepherd to ensure it reflects the latest API changes.
The text was updated successfully, but these errors were encountered: