Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing vendoring changes #98

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ibrokethecloud
Copy link
Collaborator

PR fixes missing vendor changes which are needed to ensure sbk simulator loads original timestamps and log redirection works correctly.

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, timestamp and log works.

drop need for cloning k8s.io/kubernetes and vendor it in project. Also fix up null creationTimestamp issue

drop need for cloning k8s.io/kubernetes and vendor it in project. Also fix up null creationTimestamp issue
@bk201 bk201 merged commit abc028b into rancher:master Mar 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants