Add Volume Mounts

[luthermonson]

Add's a new Volume struct which we use to add pod/container volumes. When we get them in the SUC we can then loop over and attach to all containers in the pod which will allow to let the plan decide what it needs for volumes. This will be used by the windows wins upgrade plan to mount the wins npipe socket into the container so we can break out and run wins commands.

rancher/rancher#37020

[dweomer]

As discussed in Slack:

I think what we need here is a new VolumeSpec (or MountSpec or even BindSpec) sub-type, akin to our custom SecretSpec, that references a host location/source (i.e. HostPath or Source) to mount into the containers, e.g.:

type MountSpec struct {
	Name     string `json:"name,omitempty"`
	Path     string `json:"path,omitempty"`
	HostPath string `json:"path,omitempty"`
}

You could use such in a plan to give you enough information to specify both the volumes for the pod and the references to such for individual containers (assuming you need to reference them: maybe we just mount any volumes specified for all containers?).

[dweomer]

As discussed in Slack:

I think what we need here is a new VolumeSpec (or MountSpec or even BindSpec) sub-type, akin to our custom SecretSpec, that references a host location/source (i.e. HostPath or Source) to mount into the containers, e.g.:

type MountSpec struct {
	Name     string `json:"name,omitempty"`
	Path     string `json:"path,omitempty"`
	HostPath string `json:"path,omitempty"`
}

You could use such in a plan to give you enough information to specify both the volumes for the pod and the references to such for individual containers (assuming you need to reference them: maybe we just mount any volumes specified for all containers?).

I need to think about it more to decide if I am comfortable with adding general purpose volumes to plans. 🤔

[luthermonson]

ya i agree, there is more to this than just volume mounts... le sigh

[dweomer]

Looks good (minus the nit/suggestion hinting at stylistic divergence).