Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate labels and annotations from plans to jobs #286

Merged
merged 5 commits into from Feb 27, 2024

Conversation

sfackler
Copy link
Contributor

The cattle.io filtering seems a bit sketchy - is there a better way to do that?

Closes #160

Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright to me but some tests that demonstrate it working as expected, for both inclusions and exclusions, are a must.

@sfackler
Copy link
Contributor Author

Updated!

@sfackler
Copy link
Contributor Author

I think the CI may be a bit broken? The s390x and manifest builds seem to never start running.

@brandond
Copy link
Contributor

yes, we no longer have s390x runners; those steps and the s390x manifest need to be removed.

@sfackler
Copy link
Contributor Author

Build's green!

@brandond brandond merged commit 3ffd4a3 into rancher:master Feb 27, 2024
1 check passed
@sfackler sfackler deleted the labels-annotations branch February 27, 2024 21:43
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Feb 29, 2024
….13.3 ) (patch) (#4296)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| patch | `v0.13.2` -> `v0.13.3` |
|
[rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| patch | `v0.13.2` -> `v0.13.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller
(docker.io/rancher/system-upgrade-controller)</summary>

###
[`v0.13.3`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.13.3)

[Compare
Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.13.2...v0.13.3)

#### What's Changed

- Propagate labels and annotations from plans to jobs by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[rancher/system-upgrade-controller#286
- Add a Complete condition to plans by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[rancher/system-upgrade-controller#292
- feat: Reduce permissions for system-upgrade-controller serviceaccount
by [@&#8203;SISheogorath](https://togithub.com/SISheogorath) in
[rancher/system-upgrade-controller#288
- Bump mods by [@&#8203;brandond](https://togithub.com/brandond) in
[rancher/system-upgrade-controller#293

#### New Contributors

- [@&#8203;sfackler](https://togithub.com/sfackler) made their first
contribution in
[rancher/system-upgrade-controller#286
- [@&#8203;SISheogorath](https://togithub.com/SISheogorath) made their
first contribution in
[rancher/system-upgrade-controller#288

**Full Changelog**:
rancher/system-upgrade-controller@v0.13.2...v0.13.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTkuNyIsInVwZGF0ZWRJblZlciI6IjM3LjIxOS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Feb 29, 2024
…v0.13.2 → v0.13.3 ) (#4295)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| patch | `v0.13.2` -> `v0.13.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller
(docker.io/rancher/system-upgrade-controller)</summary>

###
[`v0.13.3`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.13.3)

[Compare
Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.13.2...v0.13.3)

#### What's Changed

- Propagate labels and annotations from plans to jobs by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[rancher/system-upgrade-controller#286
- Add a Complete condition to plans by
[@&#8203;sfackler](https://togithub.com/sfackler) in
[rancher/system-upgrade-controller#292
- feat: Reduce permissions for system-upgrade-controller serviceaccount
by [@&#8203;SISheogorath](https://togithub.com/SISheogorath) in
[rancher/system-upgrade-controller#288
- Bump mods by [@&#8203;brandond](https://togithub.com/brandond) in
[rancher/system-upgrade-controller#293

#### New Contributors

- [@&#8203;sfackler](https://togithub.com/sfackler) made their first
contribution in
[rancher/system-upgrade-controller#286
- [@&#8203;SISheogorath](https://togithub.com/SISheogorath) made their
first contribution in
[rancher/system-upgrade-controller#288

**Full Changelog**:
rancher/system-upgrade-controller@v0.13.2...v0.13.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTkuNyIsInVwZGF0ZWRJblZlciI6IjM3LjIxOS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pod labels and annotations
3 participants