Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine UI and dashboard PRs in GitHub Actions workflow #206

Closed
superseb opened this issue Aug 22, 2022 · 1 comment
Closed

Combine UI and dashboard PRs in GitHub Actions workflow #206

superseb opened this issue Aug 22, 2022 · 1 comment

Comments

@superseb
Copy link

Currently we have rancher/ui and rancher/dashboard both use the GitHub Actions workflow Replace environment variable in file, which replaces the environment variable for UI and dashboard. The issue is that the one that is merged second, needs to be rebased because we are using branches in the repo itself and the commits are not in sync anymore. This is annoying and still uses too many resources.

We need to figure out how to combine those into one PR (this is based on an assumption we always have an UI and dashboard tag for a release (candidate))

@superseb
Copy link
Author

superseb commented Dec 7, 2022

This will be solved as soon as we have moved to Renovate, see an example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant