fix(docs): add 'annotations' property #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The machine_pools object supports adding annotations (required, for example, when using the rancher provider in the cluster autoscaler) but the documentation does not show this. We had to goto the source code to find this and figured others would have the same issue, adding it into the documentation can make it easier for those who do know know Go or are not programmers to find how to annotate the Machine Deployment object when doing tasks like this easily.
jakefhyde
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The machine_pools object supports adding annotations (required, for example, when using the rancher provider in the cluster autoscaler) but the documentation does not show this. We had to goto the source code to find this and figured others would have the same issue, adding it into the documentation can make it easier for those who do know know Go or are not programmers to find how to annotate the Machine Deployment object when doing tasks like this easily.