Add terraform node group node role #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-blender
force-pushed
the
node-role-terraform-support
branch
from
e55aa94
to
b57fc43
Compare
a-blender
force-pushed
the
node-role-terraform-support
branch
from
b57fc43
to
15cabeb
Compare
a-blender
force-pushed
the
node-role-terraform-support
branch
from
dc70931
to
7035a78
Compare
jiaqiluo
approved these changes
Jan 27, 2023
HarrisonWAffel
approved these changes
Jan 27, 2023
jakefhyde
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Issue: #1047
Problem
Add Terraform support for node group node role feature in EKS.
Solution
The following things have been added in this PR
eks_config_v2.node_rolefield where you can specify the EKS node group node role ARN (it will not work with just the name that is selectable from the rancher ui)node_rolenode_roleto testsTesting
Manual Testing
I tested this issue using this test plan on three EKS clusters provisioned via a local version of my Terraform provider with node role support.