Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for authenticated cluster level private registry #1055

Merged

Conversation

HarrisonWAffel
Copy link
Contributor

Issue: #1048

Problem:

The terraform documentation does not provide clear examples on how to properly configure cluster level private registries from which core system images should be pulled from. This causes a problem, as the process of properly configuring these registries for rancher v2 cluster resources is not as straight forward as it is for RKE1 clusters, leading to confusion.

Solution:

Add additional documentation on how to properly configure an authenticated cluster level registry using terraform. Add additional text around the example to also explain requirements for unauthenticated cluster level registries (simply omit values if not needed).

@HarrisonWAffel HarrisonWAffel requested review from a-blender and a team January 9, 2023 18:39
Copy link
Contributor

@a-blender a-blender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful, thank you! LGTM

@HarrisonWAffel HarrisonWAffel requested a review from a team January 18, 2023 17:19
@a-blender a-blender merged commit 86a7777 into rancher:master Feb 27, 2023
@matteogazzadi
Copy link

Sorry but example is not clear.
How can you specify the name of a Secret in the downstream cluster while you are creating the cluster itself ?

I mean in RKE1, in the private_registries section is possible to specify url, username and password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants