Add script for QA to test Terraform rcs locally #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-blender
requested review from
Josh-Diamond,
slickwarren,
thaneunsoo and
markusewalker
jakefhyde
previously requested changes
Mar 1, 2023
a-blender
requested review from
jakefhyde,
markusewalker,
thaneunsoo,
Josh-Diamond and
slickwarren
and removed request for
slickwarren,
Josh-Diamond and
thaneunsoo
a-blender
force-pushed
the
add-rc-test-script
branch
from
3016283
to
f498e69
Compare
slickwarren
reviewed
Mar 2, 2023
| curl -sfL https://github.com/rancher/terraform-provider-${PROVIDER}/releases/download/${VERSION}/terraform-provider-${PROVIDER}_${VERSION_TAG}_${OS_PLATFORM}.zip | gunzip -c - > ${DIR}/terraform-provider-${PROVIDER} | ||
|
|
||
| echo -e "Terraform provider ${PROVIDER} ${VERSION} is ready to test! | ||
| Please update the required_providers block in your Terraform config file |
There was a problem hiding this comment.
not necessary for now, but would be cool to have an optional variable to add this to the user's config file for them. i.e.
usage: $0 <provider> <version> <terraform_config_path>
slickwarren
approved these changes
Mar 2, 2023
a-blender
dismissed
jakefhyde’s stale review
Addressed all comments, the rest of the QA team has approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1083