Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump go-getter from 1.7.0 to 1.7.1 #1118

Merged
merged 1 commit into from Jul 10, 2023

Conversation

lazyfrosch
Copy link
Contributor

This is a recommended fix to avoid security alerts downloading the current release, that contained a suspicious test ZIP file.

see:

Should we re-enable dependabot for this repository? I've noticed it was enabled in the past.

This is a recommended fix to avoid security alerts downloading the
current release, that contained a suspicious test ZIP file.

see:
- https://github.com/hashicorp/go-getter/releases/v1.7.1
- hashicorp/go-getter#424
- hashicorp/go-getter#419
@a-blender a-blender requested review from kinarashah and a team July 10, 2023 08:58
Copy link
Contributor

@a-blender a-blender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbron Is there someone from the security team that can give a 2nd review?

@a-blender a-blender requested review from a team, cbron and macedogm and removed request for kinarashah July 10, 2023 08:59
Copy link
Member

@macedogm macedogm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, because the bump seems minor.

Note: I uploaded 02 zip artifacts from the v3.0.2 release and none were flagged as malicious. I don't believe that the affected false positive code (decompress_zip_test.go and testdata/decompress-zip/bomb.zip) is actually imported by us.

@a-blender a-blender merged commit 330373c into rancher:master Jul 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants