Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DO userdata default empty for v2prov #1121

Merged
merged 1 commit into from Jun 1, 2023

Conversation

jakefhyde
Copy link
Contributor

Issue: #1120

Problem

For some reason, the default userdata is populated as docker-user, when it should be empty. This prevent users from provisioning DO downstream clusters without specifying an empty userdata.

Solution

Make default empty.

Testing

I'll update this when I test it.

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

@jakefhyde jakefhyde requested review from a-blender, snasovich and a team May 13, 2023 02:26
@jakefhyde jakefhyde requested a review from a team May 16, 2023 16:03
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@jakefhyde jakefhyde merged commit 99722bd into rancher:master Jun 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants