Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default_pod_security_admission_configuration_template_name option #1144

Conversation

gregsidelinger
Copy link
Contributor

Issue: #1112

Problem

Solution

Added option to set the Rancher PSA template. When this option is present Rancher will update kube-apiserver-arg list and add - - admission-control-config-file=/etc/rancher/rke2/config/rancher-psact.yaml. This patch does not ignore this option and will cause Terraform to want to remove the setting on the next run. Was not sure how to ignore the diff so for right now I added that option to my machine-global-config settings.

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

…ion for rke2

Signed-off-by: Greg Sidelinger <sidelig@nationwide.com>
@a-blender
Copy link
Contributor

@gregsidelinger Hi! Can you please resolve the conflicts?

@a-blender a-blender requested review from a team and a-blender July 11, 2023 23:51
@a-blender a-blender changed the title Adding default_pod_security_admission_configuration_template_name option [DNM close as duplicate] Adding default_pod_security_admission_configuration_template_name option Jul 12, 2023
@a-blender a-blender closed this Jul 19, 2023
@a-blender a-blender reopened this Jul 19, 2023
@a-blender a-blender self-requested a review July 19, 2023 15:25
@a-blender a-blender changed the title [DNM close as duplicate] Adding default_pod_security_admission_configuration_template_name option Adding default_pod_security_admission_configuration_template_name option Jul 19, 2023
@lazyfrosch
Copy link
Contributor

Isn't that a duplicate of #1117 ?

@a-blender
Copy link
Contributor

@lazyfrosch Yes sorry, this is a duplicate I will close it.

@a-blender a-blender closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants