Fix Harvester disk_size default value #1149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#1150
harvester/harvester#4097
Problem
The disk_size field is an int in the Harvester node driver and will be converted to 0 by Harvester node driver if it is set to empty by the user.
Refer to https://github.com/harvester/docker-machine-driver-harvester/blob/a43dbc6d7d0091a955813ae18fc907de12b8e316/harvester/flags.go#L56
Solution
Set Harvester disk_size default value to "0" in terraform-provider-rancher2
Testing
Engineering Testing
Manual Testing
harvester-public/focal-server
and a vlan networkharvester-public/mgmt-vlan1
to the Harvester by using terraform-provider-harvesterVirtualization Management
, usefoo-harvester
as the cluster name0.0.0-dev
:terraform plan
Automated Testing
QA Testing Considerations
Regressions Considerations