New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Terraform docs for v3.1.1 patch release #1175
Add Terraform docs for v3.1.1 patch release #1175
Conversation
ba0c613
to
b962eae
Compare
23d4ed5
to
a6743e1
Compare
a6743e1
to
7243280
Compare
b54fbb5
to
f946004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small nits and a question, generally lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how to refer to an unchanged line.
Reading the cluster.md
"description" I didn't notice that it was specific for rke
, I just saw that on line 23.
The cluster_v2.md
have on the description that it can be used to create RKE2 and K3S Clusters.
I think that would be nice to add on the description of the rancher2_cluster Resource that it is used to create a rke
cluster.
@felipe-colussi The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, dont forget to squash on merge
Issue: #1186
#1097
#1112
#1199
Problem
Solution
Add TF docs for
default_pod_security_admission_configuration_template_name
RKE docs + config example with tf reconciliation error workaroundentity_id_field
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations