Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform docs for v3.1.1 patch release #1175

Merged
merged 3 commits into from Aug 2, 2023

Conversation

a-blender
Copy link
Contributor

@a-blender a-blender commented Jul 25, 2023

Issue: #1186

#1097
#1112
#1199

Problem

Solution

Add TF docs for

  • Agent customization fields + config examples
  • PSACT support: default_pod_security_admission_configuration_template_name RKE docs + config example with tf reconciliation error workaround
  • RKE auth config entity_id_field
  • Other minor updates

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

@a-blender a-blender force-pushed the tf-agent-customization-docs branch from ba0c613 to b962eae Compare July 25, 2023 16:53
@a-blender a-blender marked this pull request as draft July 25, 2023 19:07
@a-blender a-blender changed the title Add cluster/fleet agent customization docs Add Terraform docs for v3.1.1 patch release Jul 26, 2023
@a-blender a-blender force-pushed the tf-agent-customization-docs branch 2 times, most recently from 23d4ed5 to a6743e1 Compare July 26, 2023 19:21
docs/resources/cluster.md Outdated Show resolved Hide resolved
docs/resources/cluster_v2.md Outdated Show resolved Hide resolved
docs/resources/cluster_v2.md Outdated Show resolved Hide resolved
@a-blender a-blender requested review from jiaqiluo and a team August 1, 2023 14:29
Copy link
Contributor

@HarrisonWAffel HarrisonWAffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits and a question, generally lgtm

docs/resources/cluster.md Outdated Show resolved Hide resolved
rancher2/schema_cluster.go Show resolved Hide resolved
docs/resources/cluster_v2.md Outdated Show resolved Hide resolved
Copy link
Contributor

@felipe-colussi felipe-colussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to refer to an unchanged line.

Reading the cluster.md "description" I didn't notice that it was specific for rke, I just saw that on line 23.

The cluster_v2.md have on the description that it can be used to create RKE2 and K3S Clusters.

I think that would be nice to add on the description of the rancher2_cluster Resource that it is used to create a rke cluster.

@a-blender
Copy link
Contributor Author

@felipe-colussi The rancher2_cluster is only for rke clusters in Rancher so there's no need to explicitly say that, vs the v2 case where mentioning that it's also supported for k3s clusters is needed.

Copy link
Contributor

@HarrisonWAffel HarrisonWAffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, dont forget to squash on merge

@a-blender a-blender merged commit b6271c7 into rancher:master Aug 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants