Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message #1205

Merged
merged 2 commits into from Sep 19, 2023
Merged

Improve error message #1205

merged 2 commits into from Sep 19, 2023

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Aug 18, 2023 •
edited by zube bot

Issue: #1182

Problem

Bad error message.

Solution

Better error message.

Testing

n/a

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

@kkaempf kkaempf linked an issue Aug 18, 2023 that may be closed by this pull request
[RFE] Improve error message for provisioning EKS when desired_size of node groups is 0 #1182
Closed
@a-blender
Copy link
Contributor

@kkaempf CI is failing on lint, fix error msg and then we can merge.

/go/src/github.com/terraform-providers/terraform-provider-rancher2/rancher2/resource_rancher2_cluster.go:152:22: error strings should not be capitalized or end with punctuation or a newline

@kkaempf
Copy link
Contributor Author

kkaempf commented Sep 12, 2023

@kkaempf CI is failing on lint, fix error msg and then we can merge.

/go/src/github.com/terraform-providers/terraform-provider-rancher2/rancher2/resource_rancher2_cluster.go:152:22: error strings should not be capitalized or end with punctuation or a newline

Thanks, done

@kkaempf
Improve error message
294e440 
Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf
Make lint happy: drop training dot on error message
82719d5 
Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf
Copy link
Contributor Author

kkaempf commented Sep 12, 2023

Rebased to current master

@a-blender a-blender merged commit e2e1f9e into rancher:master Sep 19, 2023
1 check passed
edwin-bruurs pushed a commit to edwin-bruurs/terraform-provider-rancher2 that referenced this pull request Sep 22, 2023
@kkaempf @edwin-bruurs
Improve EKS node group desired_size error message (rancher#1205)
5c68ec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-colussi felipe-colussi felipe-colussi approved these changes

@snasovich snasovich snasovich approved these changes

@a-blender a-blender Awaiting requested review from a-blender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFE] Improve error message for provisioning EKS when desired_size of node groups is 0
4 participants
@kkaempf @a-blender @felipe-colussi @snasovich