Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_id syntax for rancher2_project_role_template_binding #1272

Merged
merged 1 commit into from Dec 8, 2023

Conversation

nemobis
Copy link
Contributor

@nemobis nemobis commented Dec 7, 2023

Previously undocumented but mentioned in
#225 (comment)

Using only the project_id produces an error:

Error: Bad response statusCode [404]. Status [404 Not Found].
Body: [message=failed to find resource by id, baseType=error,
code=NotFound] from []

Issue:

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Previously undocumented but mentioned in
rancher#225 (comment)

Using only the project_id produces an error:

> Error: Bad response statusCode [404]. Status [404 Not Found].
> Body: [message=failed to find resource by id, baseType=error,
> code=NotFound] from [<URL>]
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkaempf
Copy link
Contributor

kkaempf commented Dec 8, 2023

Thanks for your contribution !

@kkaempf kkaempf merged commit bd69d4a into rancher:master Dec 8, 2023
1 check failed
@nemobis
Copy link
Contributor Author

nemobis commented Dec 11, 2023

Thank you for the quick review!

I had pushed another commit to also document the format to be used in terraform import but it turns out it wasn't added here, I opened a new PR for that: #1274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants