-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error on rke2 cluster for Azure #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran all the tests and they are all passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs a docs change at https://github.com/rancher/terraform-provider-rancher2/blob/master/docs/resources/machine_config_v2.md?
add private_address_only
@superseb I have added the docs change. |
@02bensch I agree that we can probably drop the |
@eliyamlevy I have opened #956. I will link the necessary PRs to it when I get a chance. |
@02bensch sounds good. I've passed it along to the right people to get it approved before merging. We also have an internal issue for this but feel free to link yours as well. |
This addresses and fixes #875
After adding the
private_address_only
to the schema, we were able to successfully create the resource.