Add ec2 http_endpoint and http_tokens #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snasovich
requested review from
a team and
a-blender
and removed request for
snasovich
HarrisonWAffel
approved these changes
Jun 16, 2022
a-blender
suggested changes
Jun 16, 2022
There was a problem hiding this comment.
@HarrisonWAffel You are right! If there aren't tests for the structure file, one should be added for the flattener and expander to make sure that tf is converting the terraform config to a plan in the correct way. Use any of the other test files as a template for this
a-blender
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set http_endpoint and http_tokens for EC2 Node Templates
Issue: #943