Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add example for multiple machine pools #957

Merged
merged 2 commits into from Aug 3, 2023

Conversation

smoothzz
Copy link
Contributor

@smoothzz smoothzz commented Jul 14, 2022

Issue: #1186

This adds example for adding multiple machine pools, in the docs it says that it is a list, but after a few tests i realized that this is the right way. So would be good to have example in the official docs.

@smoothzz smoothzz changed the title add example for multiple machine pools [Docs] add example for multiple machine pools Jul 14, 2022
@euven
Copy link

euven commented Dec 7, 2022

Thanks @smoothzz - this helped me!

@Martin-Weiss
Copy link

In your example you create 1 master with all three roles and 2 worker with only worker role. Maybe it would make sense to change this to 3 master where the masters do not have the worker role and 4 workers that just have the worker role?
(Would make the cluster fault tolerant and the example more aligned with real world deployments)

@smoothzz
Copy link
Contributor Author

@Martin-Weiss yeah definitely.

@a-blender a-blender changed the title [Docs] add example for multiple machine pools [Docs] Add example for multiple machine pools Aug 2, 2023
docs/resources/cluster_v2.md Outdated Show resolved Hide resolved
docs/resources/cluster_v2.md Outdated Show resolved Hide resolved
docs/resources/cluster_v2.md Outdated Show resolved Hide resolved
@a-blender
Copy link
Contributor

@smoothzz Good initiative, thank you. Could you please make the requested changes? I'm hoping to add this to the docs patch being released today.

@smoothzz
Copy link
Contributor Author

smoothzz commented Aug 2, 2023

@smoothzz Good initiative, thank you. Could you please make the requested changes? I'm hoping to add this to the docs patch being released today.

Hello there, i just did the change you requested.

Thanks :)

@a-blender
Copy link
Contributor

a-blender commented Aug 2, 2023

@smoothzz Can you run a gofmt -w on your updated files? And/or rebase with the latest master? I think CI is failing because your branch is outdated over a year

@smoothzz
Copy link
Contributor Author

smoothzz commented Aug 2, 2023

@smoothzz Can you run a gofmt -w on your updated files? And/or rebase with the latest master? I think CI is failing because your branch is outdated over a year

i think i just did, waiting to see if the CI will fail again.

@a-blender a-blender requested a review from a team August 3, 2023 13:49
@a-blender a-blender merged commit 148cbd6 into rancher:master Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants